This repository was archived by the owner on Sep 30, 2024. It is now read-only.
internal/db: generate separate schema.md files for codeintel and frontend DBs #17228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tend DBs This is needed for us to be able to generate a schema.md file for the new Code Insights DB, which will be a separate TimescaleDB deployment / cannot be part of the same Postgres DB. Fixes #17217 (see that issue for a more detailed explanation.) Signed-off-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>
27 tasks
efritz
approved these changes
Jan 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #17228 +/- ##
=======================================
Coverage 51.98% 51.98%
=======================================
Files 1706 1706
Lines 84926 84926
Branches 7519 7510 -9
=======================================
+ Hits 44150 44153 +3
+ Misses 36873 36871 -2
+ Partials 3903 3902 -1
|
1 task
emidoots
added
code-insights
This was referenced Jan 22, 2021
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, schemadoc generates a single schema.md file for both the frontend and codeintel DBs. It does this by applying the migrations of both to the same DB and then extracting the info it needs, which is okay because Code Intel's Postgres DB and frontend are intentionally compatible and usable in the same Postgres instance (although not advised.)
For Code Insights (see #17217) I am introducing a separate TimescaleDB instance. It is basically just a Postgres plugin, but will be deploying it separately from our other Postgres instances and not designing it to be compatible with our frontend DB as codeintel has chosen to do. I am doing it this way because TimescaleDB lags a bit behind the official Postgres versioning (e.g. they are on v12) and don't want us to be tied to the version TimescaleDB supports. Also, installing the plugin is more tedious/annoying than just running it separately (and isolation is nice.)
Fixes #17217
Signed-off-by: Stephen Gutekanst stephen.gutekanst@gmail.com