This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move database connection utils to dbconn #17399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 tasks
Contributor
|
Notifying subscribers in CODENOTIFY files for diff f96e136...46ae581.
|
ryanslade
approved these changes
Jan 19, 2021
Contributor
ryanslade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you check a migration just to be sure that nothing broke there?
Contributor
Author
|
@ryanslade Not yet, once sqlhooks gets updated I will run integration tests and a migration to check if every is fine |
unknwon
approved these changes
Jan 19, 2021
tsenart
approved these changes
Jan 19, 2021
Contributor
tsenart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this if we use your fork as a dependency and update later once it's merged upstream.
Codecov Report
@@ Coverage Diff @@
## main #17399 +/- ##
==========================================
+ Coverage 51.87% 51.89% +0.01%
==========================================
Files 1716 1717 +1
Lines 85296 85275 -21
Branches 7647 7634 -13
==========================================
+ Hits 44246 44251 +5
+ Misses 37148 37124 -24
+ Partials 3902 3900 -2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently are two separate connection helpers, using two different PG drivers.
This unifies database connection helpers and merges them into one single package.
dbconnis now the only package responsible for connecting to the database and database migrations.dbutilis now only responsible for generic helpers.Note: This relies on adding support for driver.ConnBeginTx on the sqlhooks package qustavo/sqlhooks#33
Fixes #16586