This repository was archived by the owner on Sep 30, 2024. It is now read-only.
enterprise/internal/insights: add basic store package + testing infrastructure #17733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure This adds the basic store package implementation (just the groundowork, no actual implementation) based on what we do in campaigns, code monitoring, etc. I am sending this as a separate PR before implementing the store, as it is a non-trivial amount of setup code which is nice to track separately for purposes of documentation and for seeing how we can improve adding backends like this, campaigns, code monitoring, etc. in the future. Helps #17218 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
added
team/internal-contributor
code-insights
27 tasks
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 77b3ce3...199a53a.
|
Contributor
|
🤔 |
Member
Author
|
gonna reopen in a bit, I realized I need to do more work here to get this running nicely in CI + dev testing environments first (depends on timescaledb being launched via docker) |
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Member
Author
|
Ok, PTAL @efritz |
Contributor
|
|
Codecov Report
@@ Coverage Diff @@
## main #17733 +/- ##
==========================================
+ Coverage 48.10% 51.20% +3.09%
==========================================
Files 1720 1721 +1
Lines 86067 86071 +4
Branches 7699 7699
==========================================
+ Hits 41404 44069 +2665
+ Misses 40773 38109 -2664
- Partials 3890 3893 +3
|
efritz
reviewed
Jan 28, 2021
| // Store exposes methods to read and write code insights domain models from | ||
| // persistent storage. | ||
| type Store struct { | ||
| *basestore.Store |
efritz
approved these changes
Jan 28, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the basic store package implementation (just the groundowork, no
actual implementation) based on what we do in campaigns, code monitoring, etc.
I am sending this as a separate PR before implementing the store, as it is
a non-trivial amount of setup code which is nice to track separately for
purposes of documentation and for seeing how we can improve adding backends
like this, campaigns, code monitoring, etc. in the future.
Depends on: (TODO: send other PR for running timescale on CI)
Helps #17218
Fixes #17226
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com