Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@emidoots
Copy link
Member

  • Query metadata for points.
  • Improve formatting of test data.
  • Change incorrect Series *int32 to Series *string
  • Add TODOs for improved filtering abilities in the future.

Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com

* Query metadata for points.
* Improve formatting of test data.
* Change incorrect `Series *int32` to `Series *string`
* Add TODOs for improved filtering abilities in the future.

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@emidoots emidoots added team/internal-contributor code-insights Issues related to the Code Insights product labels Feb 12, 2021
@emidoots emidoots added this to the 3.25 milestone Feb 12, 2021
@emidoots emidoots requested a review from efritz February 12, 2021 23:36
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Feb 12, 2021

Notifying subscribers in CODENOTIFY files for diff 417250a...139e77d.

Notify File(s)
@felixfbecker enterprise/internal/insights/resolvers/insight_series_resolver_test.go
enterprise/internal/insights/store/store.go
enterprise/internal/insights/store/store_test.go

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@emidoots emidoots mentioned this pull request Feb 12, 2021
27 tasks
emidoots pushed a commit that referenced this pull request Feb 12, 2021
This PR adds support for the store to record data points.

Stacked on top of #18254

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@emidoots emidoots merged commit 069a64a into main Feb 15, 2021
@emidoots emidoots deleted the sg/insights-store-query-metadata branch February 15, 2021 19:30
emidoots pushed a commit that referenced this pull request Feb 15, 2021
* insights: store: add support for recording data points

This PR adds support for the store to record data points.

Stacked on top of #18254

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

code-insights Issues related to the Code Insights product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants