This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dev: allow codeinsights-db more time to startup #18359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I notice in some cases codeinsights-db needs some more time to start because my CPU is consumed by e.g. webpack or similar and building the Docker image takes a bit longer. I think we can actually make relying on the codeinsights-db on startup optional (it should be, with errors just communicated at query-time, I think) - I will send a PR to do this but for now this is better. Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
added
team/internal-contributor
code-insights
efritz
approved these changes
Feb 17, 2021
This was referenced Feb 17, 2021
This was referenced Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice in some cases codeinsights-db needs some more time to start because
my CPU is consumed by e.g. webpack or similar and building the Docker image
takes a bit longer.
I think we can actually make relying on the codeinsights-db on startup optional
(it should be, with errors just communicated at query-time, I think) - I will
send a PR to do this but for now this is better.
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com