Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@chrismwendt
Copy link
Contributor

Previously, the symbols service was suppressing file-local definitions from ctags (e.g. private variables), which was preventing jump-to-definition from working on some tokens.

This indexes file-local definitions. Here's an example:

image

This also captures the boolean fileLocal from ctags and exposes it through the GraphQL API. Without this, code intel would not be able to filter out private variables defined in other files. basic-code-intel uses fileLocal and filtering was added in sourcegraph/code-intel-extensions#63

@codecov-io
Copy link

Codecov Report

Merging #2788 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted Files Coverage Δ
cmd/symbols/internal/symbols/search.go 69.45% <ø> (ø) ⬆️
cmd/frontend/graphqlbackend/symbols.go 0% <0%> (ø) ⬆️
cmd/symbols/internal/pkg/ctags/parser.go 0% <0%> (ø) ⬆️
cmd/frontend/graphqlbackend/search.go 62.4% <0%> (ø) ⬆️
cmd/frontend/graphqlbackend/search_symbols.go 1.75% <0%> (+0.07%) ⬆️
cmd/frontend/graphqlbackend/search_suggestions.go 67.3% <0%> (ø) ⬆️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants