This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Symbols: add fileLocal field
#2788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the symbols service was suppressing file-local definitions from ctags (e.g. private variables), which was preventing jump-to-definition from working on some tokens.
This indexes file-local definitions. Here's an example:
This also captures the boolean
fileLocalfrom ctags and exposes it through the GraphQL API. Without this, code intel would not be able to filter out private variables defined in other files. basic-code-intel usesfileLocaland filtering was added in sourcegraph/code-intel-extensions#63