This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
scaletesting: bulkreposettings - allow repos to be incrementally fetched and updated #44203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
35 tasks
burmudar
commented
Nov 10, 2022
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff ba327d5...528f308.
|
burmudar
commented
Nov 10, 2022
jhchabran
reviewed
Nov 15, 2022
jhchabran
approved these changes
Nov 15, 2022
Contributor
jhchabran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Mostly nits comments, don't wait for a second round if you decide to fix them.
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the large amount of repos on certain orgs, it takes a LONG time to fetch all of the repos before we start updating them.
This reworks how repos are fetched, by fetching a batch and then updating that batch.
Closes #44141
Test plan
Tested locally / remotely too (80k repos converted so far)