This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ci/prettier: update prettier, and fix single target lint #44341
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 8ce7642 and 3960596 or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 8e28bde...8ce7642.
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 8e28bde...8ce7642.
|
burmudar
commented
Nov 14, 2022
jhchabran
approved these changes
Nov 14, 2022
38 tasks
Contributor
|
<3 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint formatting failures have been sneaking into main and it's due to a special case in a PR when the formatting check was not applied.
When format lint is applied
In the primary lint action, the formatting lint is always added unless you specify
--no-format-check.The primary lint action is executed when:
When format lint is NOT applied
The
sg lintcommand as a special case in itsBefore, where it checks how many targets there are, then deciding whether the primary action should handle the targets (targets > 1) or if it is a single target, let the subcommand action handle it.The subcommand action didn't add the formatting lint, so if your PR diff only touched one "category" like Client, then the formatting lint will not run as in this PR run.
Test plan
sg lintsg lint clientsg lint client docssg lint --no-format-checksg lint --no-format-check clientYou can also see it now picks up a format error that sneaked into main on https://buildkite.com/sourcegraph/sourcegraph/builds/183251
App preview:
Check out the client app preview documentation to learn more.