This repository was archived by the owner on Sep 30, 2024. It is now read-only.
symbols: fix regression where old env var names were not respected #48638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The env var aliasing code introduced did not work correctly, and as a result symbols searches broke in the previous version of Sourcegraph: * https://github.com/sourcegraph/sourcegraph/pull/48606 * https://sourcegraph.slack.com/archives/C02E4HE42BX/p1677787957893839 This updates the code to use `env.ChooseFallbackVariableName` - the correct way to alias env var names (thanks Erik!) - and should fix the issue. I've re-reviewed App changes to ensure these were the only two env vars renamed, so we shouldn't get bitten by this anywhere else. Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
eseliger
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env var aliasing code introduced did not work correctly, and as a result symbols searches broke in the previous version of Sourcegraph:
This updates the code to use
env.ChooseFallbackVariableName- the correct way to alias env var names (thanks Erik!) - and should fix the issue.I've re-reviewed App changes to ensure these were the only two env vars renamed, so we shouldn't get bitten by this anywhere else.
Test plan
Careful code review.