Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.0]: Use second rate limit bucket for code completions (#51522) #52094

Merged
merged 1 commit into from
May 17, 2023
Merged

[Backport 5.0]: Use second rate limit bucket for code completions (#51522) #52094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 69 additions & 2 deletions client/web/src/user/settings/quota/UserQuotaProfilePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { LoaderButton } from '../../../components/LoaderButton'
import { PageTitle } from '../../../components/PageTitle'
import { Scalars } from '../../../graphql-operations'

import { SET_USER_COMPLETIONS_QUOTA, USER_REQUEST_QUOTAS } from './backend'
import { SET_USER_CODE_COMPLETIONS_QUOTA, SET_USER_COMPLETIONS_QUOTA, USER_REQUEST_QUOTAS } from './backend'

interface Props {
user: {
Expand All @@ -22,6 +22,8 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
}) => {
const { data, loading, error } = useQuery(USER_REQUEST_QUOTAS, { variables: { userID } })
const [quota, setQuota] = useState<string>('')
const [codeCompletionsQuota, setCodeCompletionsQuota] = useState<string>('')

const [
setUserCompletionsQuota,
{
Expand All @@ -31,13 +33,28 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
},
] = useMutation(SET_USER_COMPLETIONS_QUOTA)

const [
setUserCodeCompletionsQuota,
{
data: setCodeCompletionsQuotaResponse,
loading: setUserCodeCompletionsQuotaLoading,
error: setUserCodeCompletionsQuotaError,
},
] = useMutation(SET_USER_CODE_COMPLETIONS_QUOTA)

useEffect(() => {
if (data?.node?.__typename === 'User' && data.node.completionsQuotaOverride !== null) {
setQuota(data.node.completionsQuotaOverride)
} else {
// No overridden limit.
setQuota('')
}
if (data?.node?.__typename === 'User' && data.node.codeCompletionsQuotaOverride !== null) {
setCodeCompletionsQuota(data.node.codeCompletionsQuotaOverride)
} else {
// No overridden limit.
setCodeCompletionsQuota('')
}
}, [data])

useEffect(() => {
Expand All @@ -51,6 +68,17 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
}
}, [setCompletionsQuotaResponse])

useEffect(() => {
if (setCodeCompletionsQuotaResponse) {
if (setCodeCompletionsQuotaResponse.codeCompletionsQuotaOverride !== null) {
setCodeCompletionsQuota(setCodeCompletionsQuotaResponse.codeCompletionsQuotaOverride)
} else {
// No overridden limit.
setCodeCompletionsQuota('')
}
}
}, [setCodeCompletionsQuotaResponse])

const storeCompletionsQuota = useCallback(() => {
setUserCompletionsQuota({ variables: { userID, quota: quota === '' ? null : parseInt(quota, 10) } }).catch(
error => {
Expand All @@ -59,6 +87,14 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
)
}, [quota, userID, setUserCompletionsQuota])

const storeCodeCompletionsQuota = useCallback(() => {
setUserCodeCompletionsQuota({
variables: { userID, quota: codeCompletionsQuota === '' ? null : parseInt(codeCompletionsQuota, 10) },
}).catch(error => {
logger.error(error)
})
}, [codeCompletionsQuota, userID, setUserCodeCompletionsQuota])

if (loading) {
return <LoadingSpinner />
}
Expand All @@ -84,7 +120,7 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
<Container className="mb-3">
<H3>Completions</H3>
<Text>Number of requests per day allowed against the completions APIs.</Text>
<div className="d-flex justify-content-between align-items-end">
<div className="d-flex justify-content-between align-items-end mb-5">
<Input
id="completions-quota"
name="completions-quota"
Expand Down Expand Up @@ -112,6 +148,37 @@ export const UserQuotaProfilePage: React.FunctionComponent<React.PropsWithChildr
/>
</div>
{setUserCompletionsQuotaError && <ErrorAlert error={setUserCompletionsQuotaError} className="mb-0" />}
<Text>Number of requests per day allowed against the code completions APIs.</Text>
<div className="d-flex justify-content-between align-items-end">
<Input
id="code-completions-quota"
name="code-completions-quota"
type="number"
value={codeCompletionsQuota}
onChange={event => setCodeCompletionsQuota(event.currentTarget.value)}
spellCheck={false}
min={1}
disabled={setUserCodeCompletionsQuotaLoading}
placeholder={`Global limit: ${
data?.site.perUserCodeCompletionsQuota === null
? 'infinite'
: data?.site.perUserCodeCompletionsQuota
}`}
label="Custom code completions quota"
className="flex-grow-1 mb-0"
/>
<LoaderButton
loading={setUserCodeCompletionsQuotaLoading}
label="Save"
onClick={storeCodeCompletionsQuota}
disabled={setUserCodeCompletionsQuotaLoading}
variant="primary"
className="ml-2"
/>
</div>
{setUserCodeCompletionsQuotaError && (
<ErrorAlert error={setUserCodeCompletionsQuotaError} className="mb-0" />
)}
</Container>
</>
)
Expand Down
11 changes: 11 additions & 0 deletions client/web/src/user/settings/quota/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ export const USER_REQUEST_QUOTAS = gql`
query UserRequestQuotas($userID: ID!) {
site {
perUserCompletionsQuota
perUserCodeCompletionsQuota
}
node(id: $userID) {
__typename
... on User {
completionsQuotaOverride
codeCompletionsQuotaOverride
}
}
}
Expand All @@ -22,3 +24,12 @@ export const SET_USER_COMPLETIONS_QUOTA = gql`
}
}
`

export const SET_USER_CODE_COMPLETIONS_QUOTA = gql`
mutation SetUserCodeCompletionsQuota($userID: ID!, $quota: Int) {
setUserCodeCompletionsQuota(user: $userID, quota: $quota) {
id
codeCompletionsQuotaOverride
}
}
`