This repository was archived by the owner on Sep 30, 2024. It is now read-only.
app: set name of app updater route and add it to anon api routes #52340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chwarwick
approved these changes
May 23, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
) The updater route was missing some "glue". This fixes it by: - adding it to anon api routes - naming the route ## Test plan tested locally #### No update ``` curl -o /dev/null -s -w "%{http_code}\n" "https://sourcegraph.test:3443/.api/app/check/update?target=aarch64¤t_version=2023.8.1&arch=darwin" 204 ``` #### Update! ``` curl -s "https://sourcegraph.test:3443/.api/app/check/update?target=aarch64¤t_version=2023.2.1&arch=darwin" | jq { "version": "2023.5.8+dev.123.shamd245", "notes": "Test version", "pub_date": "2023-05-07T12:25:57Z", "signature": "dW50cnVzdGVkIGNvbW1lbnQ6IHNpZ25hdHVyZSBmcm9tIHRhdXJpIHNlY3JldCBrZXkKUlVTWVByYmswNFZITlB3UDZaQUE1WnlrZEYxMzBZd1hNYVY5U2U0dGJmZzZNUm1aTDdoMzF3TFNoYlo5VFRiblI5NTQzV2NsS1J0TWZUSmFJQXVmejV1U1p2WXo5ZWhDMGc4PQp0cnVzdGVkIGNvbW1lbnQ6IHRpbWVzdGFtcDoxNjgzNTQzMzgyCWZpbGU6U291cmNlZ3JhcGguQXBwXzEuMC4wLWRldl94NjQuZG1nCmdGM1NDODlWNmJFdEpyUGZNd3orYzdYT1pjOXFjMFJQZXBqNG00ZC9zTC9vajBrakVzSkV5OGRIUE4zak1aSlNVZDN5eXc2YVNRNWs3elovZ3Z1bkJnPT0K", "url": "https://github.com/sourcegraph/sourcegraph/releases/download/untagged-03042cee5585262192cf/Sourcegraph.App_1.0.0-dev_x64.dmg" } ``` <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updater route was missing some "glue". This fixes it by:
Test plan
tested locally
No update
Update!