This repository was archived by the owner on Sep 30, 2024. It is now read-only.
bazel: add config setting for zig linux 86 and incompatible cc #52364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
commented
May 24, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 556e5c5...04b239d.
|
davejrt
approved these changes
May 24, 2023
jhchabran
approved these changes
May 25, 2023
burmudar
added a commit
that referenced
this pull request
May 25, 2023
#52364)" (#52457) Main is blocked because of this commit This reverts commit 7e6ca20. ## Test plan none - this is a revert <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
For some bazel targets we want bazel to detect the host cc and use it. This puts the `--incompatible_enable_cc_toolchain_resolution` flag behind a config setting one has to opt into to use with `--config incompat-zig-linux-amd64`. I also extracted some of the bazelrc to selectively add the CI bazelrc, so that it is easier to run these scripts locally. ## Test plan * green ci * executed the symbols and server scripts locally <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
#52364)" (#52457) Main is blocked because of this commit This reverts commit 7e6ca20. ## Test plan none - this is a revert <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some bazel targets we want bazel to detect the host cc and use it. This puts the
--incompatible_enable_cc_toolchain_resolutionflag behind a config setting one has to opt into to use with--config incompat-zig-linux-amd64.I also extracted some of the bazelrc to selectively add the CI bazelrc, so that it is easier to run these scripts locally.
Test plan