This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody completions: Log multi-line completion requests and results #52449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
requested review from
a team,
abeatrix,
beyang,
lrhacker and
valerybugakov
github-actions
bot
added
the
team/code-exploration
Contributor
vdavid
reviewed
May 25, 2023
client/cody/src/main.ts
Outdated
| await completionsProvider.fetchAndShowCompletions() | ||
| }), | ||
| vscode.commands.registerCommand('cody.completions.inline.accepted', () => { | ||
| vscode.commands.registerCommand('cody.completions.inline.accepted', asdf => { |
vdavid
reviewed
May 25, 2023
vdavid
approved these changes
May 25, 2023
Contributor
vdavid
left a comment
vdavid
left a comment
There was a problem hiding this comment.
Nice little improvement. Pointed out a possibly accidental change
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
) Adds a flag to the event logs so we know how often multi-line suggestions are triggered. Logging how often they are accepted is a bit tricker and requires some resturcturing. For now we do not know for an accepted event wether it was a multi line or a single line completion. Will fix it up later (but I plan to cut a release in a bit) ## Test plan <img width="1092" alt="Screenshot 2023-05-25 at 14 14 15" src="https://github.com/sourcegraph/sourcegraph/assets/458591/da3ed4c4-b0c2-4906-9680-b6324c483c04"> <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to the event logs so we know how often multi-line suggestions are triggered.
Logging how often they are accepted is a bit tricker and requires some resturcturing. For now we do not know for an accepted event wether it was a multi line or a single line completion. Will fix it up later (but I plan to cut a release in a bit)
Test plan