Skip to content
This repository was archived by the owner on Jun 7, 2022. It is now read-only.

Remove path-browserify #142

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Remove path-browserify #142

merged 1 commit into from
Apr 1, 2019

Conversation

@felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Mar 30, 2019

Context: #139 (comment)

I did not get any errors with using import * as path from 'path'. Using require() makes every interaction with path not type safe because it is type any.

@felixfbecker felixfbecker merged commit c7d0b39 into master Apr 1, 2019
@felixfbecker felixfbecker deleted the no-path-browserify branch April 1, 2019 12:05
@chrismwendt chrismwendt mentioned this pull request Apr 1, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chrismwendt chrismwendt chrismwendt approved these changes

@lguychard lguychard lguychard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrismwendt chrismwendt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixfbecker @chrismwendt @lguychard