Skip to content

Conversation

@bavulapati
Copy link
Contributor

Reported by clang-tidy check misc-include-cleaner
Refs: sourcemeta/blaze#429

Reported by clang-tidy check `misc-include-cleaner`
Refs: sourcemeta/blaze#429

Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
@jviotti
Copy link
Member

jviotti commented May 18, 2025

As with the other PRs, please follow the include styles, like the actual ordering, <...> style, comments on why the system includes were pulled in, etc. Overall try to copy the current style in all of the files!

Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
@bavulapati
Copy link
Contributor Author

@jviotti addressed the review comments. PTAL

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@jviotti jviotti merged commit 863da9f into sourcemeta:main May 21, 2025
13 checks passed
@bavulapati bavulapati deleted the include-clean-src-core-json branch May 21, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants