-
Notifications
You must be signed in to change notification settings - Fork 275
fix: add number of lines stats per commit, add binary filter, other minor fixes #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| companion object { | ||
| val LANGUAGE_NAME = "objectivec" | ||
| val FILE_EXTS = listOf("h", "m", "mm") | ||
| val FILE_EXTS = listOf("m", "mm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I know .h is valid file extension for object c, at least it's in use in Gecko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but for now we can't distinguish h file from C/C++ or ObjectiveC. This extension will be introduced with ANTLR parsing of files.
src/main/proto/sourcerer.proto
Outdated
| string author_email = 5; | ||
|
|
||
| // Timestamp of a commit creation. | ||
| // Timestamp of a commit creation in seconds UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what UTC stands for, do you refer to 0 longitude or a time format in general? It might be worth to brace 'UTC' word if you refer to the time format, otherwise explicit 'at 0° longitude' will be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean UTC+00:00.
| compile 'com.github.kittinunf.fuel:fuel-rxjava:1.9.0' | ||
| compile group: 'org.eclipse.jgit', name: 'org.eclipse.jgit', | ||
| version: '4.8.0.201706111038-r' | ||
| compile "org.slf4j:slf4j-nop:1.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how this exactly works, I trust you though on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JGit use SLF4J API, nop is an empty implementation of this api (stands for no operation).
No description provided.