Skip to content

Conversation

@astansler
Copy link
Member

No description provided.

@astansler astansler self-assigned this Sep 11, 2017
@astansler astansler requested a review from asurkov September 11, 2017 14:49
companion object {
val LANGUAGE_NAME = "objectivec"
val FILE_EXTS = listOf("h", "m", "mm")
val FILE_EXTS = listOf("m", "mm")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I know .h is valid file extension for object c, at least it's in use in Gecko

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but for now we can't distinguish h file from C/C++ or ObjectiveC. This extension will be introduced with ANTLR parsing of files.

string author_email = 5;

// Timestamp of a commit creation.
// Timestamp of a commit creation in seconds UTC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what UTC stands for, do you refer to 0 longitude or a time format in general? It might be worth to brace 'UTC' word if you refer to the time format, otherwise explicit 'at 0° longitude' will be nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean UTC+00:00.

compile 'com.github.kittinunf.fuel:fuel-rxjava:1.9.0'
compile group: 'org.eclipse.jgit', name: 'org.eclipse.jgit',
version: '4.8.0.201706111038-r'
compile "org.slf4j:slf4j-nop:1.7.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this exactly works, I trust you though on this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JGit use SLF4J API, nop is an empty implementation of this api (stands for no operation).

@astansler astansler merged commit 50a5f01 into master Sep 11, 2017
@astansler astansler deleted the dev-stats branch September 11, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants