Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/main/kotlin/app/extractors/CExtractor.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class CExtractor : ExtractorInterface {
companion object {
val LANGUAGE_NAME = "c"
val FILE_EXTS = listOf("c")
val evaluator = ExtractorInterface.getLibrariesModelEvaluator(LANGUAGE_NAME)
}

override fun extract(files: List<DiffFile>): List<CommitStats> {
Expand All @@ -32,4 +33,18 @@ class CExtractor : ExtractorInterface {

return imports.toList()
}

override fun tokenize(line: String): List<String> {
val importRegex = Regex("""^([^\n]*#include)\s[^\n]*""")
val commentRegex = Regex("""^([^\n]*//)[^\n]*""")
var newLine = importRegex.replace(line, "")
newLine = commentRegex.replace(newLine, "")
return super.tokenize(newLine)
}

override fun getLineLibraries(line: String,
fileLibraries: List<String>): List<String> {

return super.getLineLibraries(line, fileLibraries, evaluator, LANGUAGE_NAME)
}
}
9 changes: 9 additions & 0 deletions src/main/kotlin/app/extractors/ExtractorInterface.kt
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,15 @@ interface ExtractorInterface {
return emptyList()
}

// For C language.
// Consider line with language label being the one with high probability
// as not having library.
// Keep it while the number of libraries is small.
if (languageLabel == CExtractor.LANGUAGE_NAME &&
languageLabel in selectedCategories) {
return emptyList()
}

val lineLibraries = fileLibraries.filter { it in selectedCategories }
return lineLibraries
}
Expand Down
11 changes: 11 additions & 0 deletions src/test/kotlin/test/tests/extractors/ExtractorTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ class ExtractorTest : Spek({
assertExtractsLineLibraries("Tebru\\Retrofit",
line, PhpExtractor())
}

it("c extractor extracts the library") {
val line = "grpc_test_init(argc, argv);"
assertExtractsLineLibraries("grpc",
line, CExtractor())
}
}

given("code line doesn't use libraries" ) {
Expand Down Expand Up @@ -142,5 +148,10 @@ class ExtractorTest : Spek({
val line = "std::cerr << status.ToString() << std::endl;"
assertExtractsNoLibraries(line, CppExtractor())
}

it("c extractor returns empty list") {
val line = "int main(int argc, char **argv) {"
assertExtractsNoLibraries(line, CExtractor())
}
}
})