Metrics #57
Merged
Metrics #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astansler
reviewed
Nov 4, 2017
| /** | ||
| * Records a numeric metric of given tag. | ||
| */ | ||
| fun recordMetric(tag: String, metric: Long) |
Member
There was a problem hiding this comment.
What this function used for? Storing of numbers?
Contributor
Author
There was a problem hiding this comment.
right, just accumulating numeric values, for example, it's useful, when you're recording the timing of line insertions and removals, and you want to know the ratio of inserted and removed lines. It is a very basic feature for sure, but often helpful.
astansler
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if we really need it, but I find these methods useful for bottlenecks analysis - just put a bunch of recordTime {} calls, which could be nested, and you will see timing of which block takes what time.
Note, the PR contains changes from another PR, just ignore them, you are interested in the last one.