APP-141: report Longevity's crashes to Logger #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astansler
reviewed
Nov 8, 2017
| } | ||
|
|
||
| getDiffsObservable(tail).blockingSubscribe { (commit, diffs) -> | ||
| getDiffsObservable(tail).subscribe( { (commit, diffs) -> |
Member
There was a problem hiding this comment.
Asynchronous subscribe. Is it working not in a test mode?
Contributor
Author
There was a problem hiding this comment.
You mean if it was called from Main, then yes, it seems so. The problem of blockingSubscribe is it collects all items before the items are delivered to a consumer, which is a bit slower than it could be.
Contributor
Author
There was a problem hiding this comment.
@anatolykislov if you are skeptical about subscribe part, then let's back it out and deal with it separately in different issue?
asurkov
force-pushed
the
lgv_reporterror
branch
from
b83542e to
948bd67
Compare
astansler
approved these changes
Nov 14, 2017
| // TODO(anatoly): CodeLongevity hash from observable. | ||
| try { | ||
| CodeLongevity(serverRepo, filteredEmails, git).updateStats(api) | ||
| CodeLongevity(serverRepo, filteredEmails, git, onError). |
Member
There was a problem hiding this comment.
It's better to move point to next line :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.