fix(longevity) - multiple renames are not handled properly (APP-132) #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astansler
approved these changes
Nov 8, 2017
Member
astansler
left a comment
astansler
left a comment
There was a problem hiding this comment.
Add todo about required tests, please. We rely on undocumented behaviour of JGit that differs from git and may be changed later.
asurkov
force-pushed
the
lgv_doublerenames
branch
2 times, most recently
from
7f3e9ab to
c9ba121
Compare
asurkov
force-pushed
the
lgv_doublerenames
branch
from
c9ba121 to
c4eb411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tests, we need something more complicated than deleteFile/removeFile/deleteFile sequence as JGit prefers to not generate double renames. Not sure what it could be.