feat: refactor config and files storing (APP-154) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
astansler
commented
Nov 23, 2017
astansler
commented
- JAR directory changed
- Configs and data files (e.g. longevity incremental update data, models) storing in the same directory where JAR located
asurkov
approved these changes
Nov 24, 2017
| return getPath(name, *parts).toFile() | ||
| } | ||
|
|
||
| fun isNotExists(name:String, vararg parts: String): Boolean { |
Contributor
There was a problem hiding this comment.
I would prefer notExists, same as Files.notExists and a bit better english
| import java.nio.file.Paths | ||
| import java.nio.file.Path | ||
|
|
||
| object FileHelper { |
Contributor
There was a problem hiding this comment.
a small comment please that this class is a wrapper around java Paths and Files classes to work the sourcerer's files.
| val fullPath = Paths.get(fullPathString) | ||
| val root = fullPath.root | ||
| // Removing jar filename. | ||
| return root.resolve(fullPath.subpath(0, fullPath.nameCount - 1)) |
Contributor
There was a problem hiding this comment.
might be unexpected behavior for the user, if the user moved a jar file, and we put all our stuff next to it, @sergey-surkov is it ok?
Member
Author
There was a problem hiding this comment.
Why would the user want to do it? We use bash script that points to a specific location of the JAR to run sourcerer, all will be broken anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.