Skip to content

Drop legacy dbs, add optional phpMyAdmin, start deprecation of networks. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 6, 2020
Merged

Drop legacy dbs, add optional phpMyAdmin, start deprecation of networks. #10

merged 13 commits into from
Mar 6, 2020

Conversation

@iBotPeaches
Copy link
Member

@iBotPeaches iBotPeaches commented Mar 5, 2020 •
edited
Loading

  • I don't believe any projects is using 56 anymore, if so please PM me.
  • Maria102 is a year+ away from going EOL, so we need to add the next major for project opt-in.
  • New DB leverages our internal "st-internal" network so we don't have an n+1 problem with network creation.

Screen Shot 2020-03-05 at 9 38 41 AM

  • We can now support multiple hosts via one management system.
  • Start deprecation of specific service networks for one

CHANGES

  • Dropped mysql56
  • Added mariadb103
  • Added mariadb104
  • Added optional phpmyadmin (hooks to all 3 marias)
  • Updated examples for Yii2/Laravel, updating PHP
  • Dropped network creation (deprecation)
  • Kept old networks for backward compatibility

IF MERGED

  • Projects should opt into st-internal for service specific things before the network dies

@iBotPeaches iBotPeaches requested a review from jweberst March 5, 2020 14:29
jyann
jyann previously approved these changes Mar 5, 2020
View reviewed changes
jweberst
jweberst reviewed Mar 5, 2020
View reviewed changes
@iBotPeaches iBotPeaches changed the title Drop mysql56, add maria103 Drop legacy dbs, add optional phpMyAdmin, start deprecation of networks. Mar 5, 2020
jweberst
jweberst previously approved these changes Mar 5, 2020
View reviewed changes
jweberst
jweberst previously approved these changes Mar 5, 2020
View reviewed changes
joeladam518
joeladam518 previously approved these changes Mar 5, 2020
View reviewed changes
@iBotPeaches iBotPeaches dismissed stale reviews from joeladam518 and jweberst via e7b259d March 5, 2020 15:19
joeladam518
joeladam518 previously approved these changes Mar 5, 2020
View reviewed changes
@marshall-davis
Copy link
Contributor

marshall-davis commented Mar 5, 2020 •
edited by iBotPeaches
Loading

I recently got a project running locally via Docker on Mysql56. I would assume it could run on the MariaDB server but I haven't checked yet.

whoisgregg
whoisgregg previously approved these changes Mar 5, 2020
View reviewed changes
@iBotPeaches iBotPeaches dismissed stale reviews from whoisgregg and joeladam518 via 2632bfa March 5, 2020 17:11
@marshall-davis
Copy link
Contributor

marshall-davis commented Mar 5, 2020

I recently got a project running locally via Docker on Mysql56. I would assume it could run on the MariaDB server but I haven't checked yet.

I can now confirm that after a bit of struggle I can at least get as far on the Maria instances as I could on MySQL.

nicomaurer
nicomaurer approved these changes Mar 6, 2020
View reviewed changes
Copy link

@nicomaurer nicomaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠👍

@iBotPeaches iBotPeaches merged commit a737009 into master Mar 6, 2020
@iBotPeaches iBotPeaches deleted the drop-mysql56-add-maria103 branch March 6, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeladam518 joeladam518 joeladam518 approved these changes

@jweberst jweberst jweberst approved these changes

@Jasonej Jasonej Jasonej approved these changes

@michalm-st michalm-st michalm-st approved these changes

@jyann jyann jyann left review comments

+3 more reviewers

@marshall-davis marshall-davis marshall-davis approved these changes

@nicomaurer nicomaurer nicomaurer approved these changes

@whoisgregg whoisgregg whoisgregg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@iBotPeaches @marshall-davis @whoisgregg @jyann @joeladam518 @jweberst @Jasonej @michalm-st @nicomaurer