Validate core assembly reference when loading mods

[CJ-SPT]

Validate the core assembly reference version when loading mods, give it a more description exception and kill the server if it requires a newer SPT version than the one being ran.

[qodo-merge-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Prevent null reference and improve version parsing Suggestion Impact: The commit added a null check for the referenced assembly version before proceeding, preventing a potential NullReferenceException. However, it did not implement the improved version construction from components and kept the string slicing approach. code diff: .GetReferencedAssemblies() .FirstOrDefault(asm => asm.Name == "SPTarkov.Server.Core") ?.Version?.ToString(); + + if (sptCoreAsmRefVersion is null) + { + continue; + } var modRefVersion = new SemanticVersioning.Version(sptCoreAsmRefVersion?[..^2]!); Add a null check for the assembly reference to prevent a potential NullReferenceException and construct the version object directly from its components to avoid fragile string parsing. SPTarkov.Server/Modding/ModValidator.cs [170-182] -var sptCoreAsmRefVersion = assembly +var sptCoreAsmRef = assembly .GetReferencedAssemblies() - .FirstOrDefault(asm => asm.Name == "SPTarkov.Server.Core") - ?.Version?.ToString(); + .FirstOrDefault(asm => asm.Name == "SPTarkov.Server.Core"); -var modRefVersion = new SemanticVersioning.Version(sptCoreAsmRefVersion?[..^2]!); +if (sptCoreAsmRef?.Version is null) +{ + continue; +} + +var modRefVersion = new SemanticVersioning.Version( + sptCoreAsmRef.Version.Major, + sptCoreAsmRef.Version.Minor, + sptCoreAsmRef.Version.Build +); + if (modRefVersion > sptVersion) { throw new Exception( $"Mod: {modName} requires a minimum SPT version of `{modRefVersion}`, but you are running `{sptVersion}`. Please update SPT to use this mod." ); } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a potential NullReferenceException that would crash the application, and also points out fragile string manipulation, providing a much more robust implementation.	Medium
Update

[ArchangelWTF]

LGTM