Update Go client to 1.2.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
approved these changes
Jan 26, 2025
Member
rnestler
left a comment
rnestler
left a comment
There was a problem hiding this comment.
Should we also mention this in the release checklist? See https://github.com/SpaceApi/schema/pull/123/files
Contributor
Author
Why? The validator OpenAPI client is unaffected by schema versions. It only needs to be updated when the validator's API changes. |
Member
Ah to me it seemed because of the schema changes we'd also need to update this client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the go-spaceapi-validator-client to the current version 1.2.0 of the spec.
It also adds instructions on how to update the client, because I just had to reverse engineer that part.