update py-notebook #13423
update py-notebook #13423
Conversation
|
For the record, I'm renaming |
|
Same question as in the other PR: Which merge-order do you prefer? |
|
No preference, we just need to remember to update based on which is merged first. |
|
|
||
| variant('terminal', default=False, description="Enable terminal functionality") | ||
|
|
||
| depends_on('python@2.7:2.8,3.3:') |
There was a problem hiding this comment.
| depends_on('python@2.7:2.8,3.3:') | |
| depends_on('python@2.7:2.8,3.3:', type=('build', 'run')) | |
| depends_on('python@3.5:', when='@6:', type=('build', 'run')) |
It's probably worth adding the latest version of Notebook 5.X so we have a more up-to-date version for Python 2 users.
| depends_on('python@2.7:2.8,3.3:') | ||
| depends_on('py-setuptools', type='build', when='@6:') | ||
| depends_on('py-jinja2', type=('build', 'run')) | ||
| depends_on('py-tornado@4:', type=('build', 'run')) |
There was a problem hiding this comment.
| depends_on('py-tornado@4:', type=('build', 'run')) | |
| depends_on('py-tornado@5.0:', type=('build', 'run')) |
| # right now treat them as 6-or-newer dependencies | ||
| depends_on('py-prometheus-client', type=('build', 'run'), when='@6:') | ||
| depends_on('py-terminado', type=('build', 'run'), when='@6:') | ||
| depends_on('py-send2trash', type=('build', 'run'), when='@6:') |
There was a problem hiding this comment.
Missing dependencies and version constraints on:
'pyzmq>=17',
'traitlets>=4.2.1',
'jupyter_core>=4.4.0',
'jupyter_client>=5.3.1',
'terminado>=0.8.1',
':python_version == "2.7"': ['ipaddress'], Also, py-jupyter-console is not required.
|
Ping @healther, needs a rebase |
* add setuptools dependency for newer version the whole jupyter collection seems to use setuptools in case of certain setup.py-arguments from the very beginning. However the latest ones actually require it, otherwise the build will fail * add newly introduced dependencies
healther
force-pushed
the
PR/pynotebook
branch
from
102b365 to
1c21a11
Compare
|
Done, requires the other |
|
Travis fail is unrelated, but a |
|
|
||
| variant('terminal', default=False, description="Enable terminal functionality") | ||
|
|
||
| depends_on('python@2.7:2.8,3.3:') |
There was a problem hiding this comment.
The latest version only supports Python 3.5+. Also, need type=('build', 'run').
| version('4.0.4', sha256='a57852514bce1b1cf41fa0311f6cf894960cf68b083b55e6c408316b598d5648') | ||
| version('4.0.2', sha256='8478d7e2ab474855b0ff841f693983388af8662d3af1adcb861acb900274f22a') | ||
|
|
||
| variant('terminal', default=False, description="Enable terminal functionality") |
There was a problem hiding this comment.
I would honestly just get rid of this variant. It isn't present in the setup.py, and terminado was never required until recent versions.
There was a problem hiding this comment.
not sure about this as it might break older things (and presumably people cared enough to add it), it was there till the very beginning.
Anyways: Semi-related side rant: github history does not work over renames so git log var/spack/repos/builtin/packages/py-notebook/package.py only works till 2264e30
2 participants
the whole jupyter collection seems to use setuptools in case of
certain setup.py-arguments from the very beginning. However the latest
ones actually require it, otherwise the build will fail