fix: address code review findings across spec and TCK#42
Merged
peter-svensson merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
9658b00 to
d2e19f9
Compare
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunTCKWithReportby addingsync.Mutexaround report mutationsreadResponse(subprocess killed immediately after)Kind*constants fromnaming.go, use typedExchangeKindconstantshttp.Getwithhttp.NewRequestWithContext+ basic auth in TCK broker clientcontext.WithTimeouttofetchJSONindiscover.goanddeleteResourceinbroker_amqp.gocliRunner.Runto guarantee execution on paniccoverage.go(11, not 9)RoutingKeyOverlapsto single return statementstrings.NewReplacerat package level instead of nestedstrings.ReplacereadTopologyhelper to fixdefer f.Close()in loopwriteResult/writeErrorin adapterutilDurationis in nanosecondsErrParseJSONerror messagecrypto/randerror inrandomSuffixstyleline per node ID for spec complianceTest plan
go vet ./...passesgo build ./...passesgo test ./... -shortpasses (updated visualize test expectations)