Skip to content

fix: address code review findings across spec and TCK#42

Merged
peter-svensson merged 1 commit intomainfrom
fix/code-review-findings
Apr 1, 2026
Merged

fix: address code review findings across spec and TCK#42
peter-svensson merged 1 commit intomainfrom
fix/code-review-findings

Conversation

@peter-svensson
Copy link
Copy Markdown
Member

@peter-svensson peter-svensson commented Apr 1, 2026

Summary

  • Fix data race in RunTCKWithReport by adding sync.Mutex around report mutations
  • Add goroutine leak comment in readResponse (subprocess killed immediately after)
  • Remove duplicate Kind* constants from naming.go, use typed ExchangeKind constants
  • Replace bare http.Get with http.NewRequestWithContext + basic auth in TCK broker client
  • Add context.WithTimeout to fetchJSON in discover.go and deleteResource in broker_amqp.go
  • Move cleanup loop into deferred function in cliRunner.Run to guarantee execution on panic
  • Fix stale comment count in coverage.go (11, not 9)
  • Simplify RoutingKeyOverlaps to single return statement
  • Use strings.NewReplacer at package level instead of nested strings.Replace
  • Extract readTopology helper to fix defer f.Close() in loop
  • Return write errors from writeResult/writeError in adapterutil
  • Add doc comment specifying Duration is in nanoseconds
  • Improve ErrParseJSON error message
  • Panic on crypto/rand error in randomSuffix
  • Emit one Mermaid style line per node ID for spec compliance

Test plan

  • go vet ./... passes
  • go build ./... passes
  • go test ./... -short passes (updated visualize test expectations)

@peter-svensson peter-svensson enabled auto-merge (squash) April 1, 2026 19:23
@peter-svensson peter-svensson force-pushed the fix/code-review-findings branch from 9658b00 to d2e19f9 Compare April 1, 2026 19:23
@peter-svensson peter-svensson changed the title fix: address code review findings fix: address code review findings across spec and TCK Apr 1, 2026
@peter-svensson peter-svensson disabled auto-merge April 1, 2026 20:48
@peter-svensson peter-svensson merged commit 874ab17 into main Apr 1, 2026
4 checks passed
@peter-svensson peter-svensson deleted the fix/code-review-findings branch April 1, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant