Add reso versioning #182
Add reso versioning #182
Conversation
We should be able to alter the version of the RESO Web API we are hitting. This change should allow for that using the already existing `version` configuration option. That option was initially spark-only since the RESO Web API did not exist yet.
dgmyrek
left a comment
dgmyrek
left a comment
There was a problem hiding this comment.
I couldn't get this to work in testing. The URI seemed to be locked to the default (no /Version/x in the path) regardless of whether I tried setting SparkApi.client.version to the integer or string value "2".
lib/spark_api/request.rb
Outdated
| request_path = if middleware && middleware.to_sym == :reso_api | ||
| dd_version = "Dictionary/#{dictionary_version}/" unless dictionary_version.nil? | ||
| "/Reso/#{dd_version}OData#{path}" | ||
| "/Version/#{version}/Reso/#{dd_version}OData#{path}" |
There was a problem hiding this comment.
Does setting the :reso_api flag set a different default version than the Spark API's "v1"?
I'm wondering if the default value of this variable needs to be updated on the fly to be compatible with this new RESO API code path:
spark_api/lib/spark_api/configuration.rb
Line 37 in 8500003
There was a problem hiding this comment.
I agree, @dgmyrek. The way this was built was to take into account that parameter under all circumstances. Instead of having a computed default, I opted to ignore this parameter unless it is not the default.
We should be able to alter the version of the RESO Web API we are
hitting. This change should allow for that using the already existing
versionconfiguration option. That option was initially spark-onlysince the RESO Web API did not exist yet.