refs platform/board#3920: check if membership exist

[FabrizioCafolla]

PR Type

Enhancement

---

Description

• Add data source to check existing project memberships

• Export project memberships through new output variable

• Enable membership validation before assignment operations

• Support membership existence checks for GitLab projects

---

Changes walkthrough 📝

Relevant files

Enhancement

main.tf Add project membership data source                                              main.tf Add gitlab_project_membership data source to fetch existing memberships Reference local project ID for membership lookup +4/-0      outputs.tf Export project memberships output                                                outputs.tf Add new output gitlab_project_memberships Export current user memberships list from data source +4/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue The data source is fetching project memberships but there's no conditional logic to check membership existence before the membership resource creation. The PR description mentions enabling membership validation, but the code doesn't implement any validation logic. data "gitlab_project_membership" "this" { project_id = local.project_id } resource "gitlab_project_membership" "project" { count = var.autoassign_current_user_as_maintainer ? 1 : 0 project = local.project_id user_id = data.gitlab_current_user.this.id Resource Dependency The data source may fail if the project doesn't exist or if there are insufficient permissions to read memberships. Consider adding error handling or conditional logic based on project existence. data "gitlab_project_membership" "this" { project_id = local.project_id }

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add conditional for data source The data source will fail if the project doesn't exist or if there are no memberships. Add a lifecycle block with ignore_changes or wrap in a conditional to handle cases where the project might not have any members. main.tf [94-96] data "gitlab_project_membership" "this" { + count = local.project_id != null ? 1 : 0 project_id = local.project_id } Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential issue where the data source could fail if local.project_id is null or the project doesn't exist. Adding a conditional count prevents resource creation errors.	Medium
	Handle null membership data safely The output will fail if the data source doesn't exist or returns null. Use a conditional expression or try() function to handle cases where memberships might not be available. outputs.tf [47-50] output "gitlab_project_memberships" { description = "List of current user memberships in the Gitlab project where the Gitlab Agents are installed." - value = data.gitlab_project_membership.this.members + value = try(data.gitlab_project_membership.this.members, []) } Suggestion importance[1-10]: 6 __ Why: The suggestion addresses a potential runtime error when accessing data.gitlab_project_membership.this.members if the data source fails or returns null. Using try() provides a safe fallback with an empty list.	Low

[FabrizioCafolla]

/improve

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

No code suggestions found for the PR.

[Copilot]

Pull Request Overview

This PR enhances the GitLab project membership handling by adding validation to check if the current user is already a maintainer before attempting to assign membership. This prevents conflicts when the user already has project access.

• Add data source to fetch existing project memberships
• Implement logic to check if current user is already a maintainer
• Conditionally assign membership only when user is not already a maintainer

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
main.tf	Adds membership data source and conditional logic to prevent duplicate membership assignments
outputs.tf	Removes trailing whitespace
README.md	Documents the membership behavior and potential conflicts

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}