Skip to content

v2.2.10 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2023
Merged

v2.2.10 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
583566f
Bump version number to v2.2.10
sfe-SparkFro Dec 14, 2023
e29ef61
Fix setColonOnOff() and setDecimalOnOff()
sfe-SparkFro Dec 14, 2023
58e247f
Ensure write() does not wrap with long inputs
sfe-SparkFro Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=SparkFun Qwiic Alphanumeric Display Arduino Library
version=2.2.9
version=2.2.10
author=SparkFun Electronics
maintainer=SparkFun Electronics
sentence=A library to drive the Holtek HT16K33 LED Driver with an Alphanumeric Display.
Expand Down
11 changes: 8 additions & 3 deletions src/SparkFun_Alphanumeric_Display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,8 @@ bool HT16K33::setDecimalOnOff(uint8_t displayNumber, bool turnOnDecimal, bool up
dat = 0x00;
}

displayRAM[adr + (displayNumber - 1) * 16] = displayRAM[adr + (displayNumber - 1) * 16] | dat;
displayRAM[adr + (displayNumber - 1) * 16] &= 0xFE;
displayRAM[adr + (displayNumber - 1) * 16] |= dat;

if(updateNow)
{
Expand Down Expand Up @@ -547,7 +548,8 @@ bool HT16K33::setColonOnOff(uint8_t displayNumber, bool turnOnColon, bool update
dat = 0x00;
}

displayRAM[adr + (displayNumber - 1) * 16] = displayRAM[adr + (displayNumber - 1) * 16] | dat;
displayRAM[adr + (displayNumber - 1) * 16] &= 0xFE;
displayRAM[adr + (displayNumber - 1) * 16] |= dat;

if(updateNow)
{
Expand Down Expand Up @@ -759,6 +761,10 @@ size_t HT16K33::write(uint8_t b)
*/
size_t HT16K33::write(const uint8_t *buffer, size_t size)
{
// Do not exceed number of digits available
if(size > 4 * numberOfDisplays)
size = 4 * numberOfDisplays;

size_t n = size;
uint8_t buff;

Expand All @@ -782,7 +788,6 @@ size_t HT16K33::write(const uint8_t *buffer, size_t size)
displayContent[digitPosition] = buff; // Record to internal array

digitPosition++;
digitPosition %= (numberOfDisplays * 4);
}
}

Expand Down