Skip to content

VCT: Validate the srcVC before indexing the virtualCircuitList #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023
Merged

VCT: Validate the srcVC before indexing the virtualCircuitList #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion Firmware/Tools/VcServerTest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,27 @@ void radioCommandComplete(VC_SERIAL_MESSAGE_HEADER * header, uint8_t * data, uin
//The command processor is still running
commandProcessorRunning = STALL_CHECK_COUNT;

//Done with this command
//Validate the srcVc
srcVc = header->radio.srcVc;
if (srcVc >= PC_REMOTE_COMMAND)
{
if (srcVc < (uint8_t)VC_RSVD_SPECIAL_VCS)
srcVc &= VCAB_NUMBER_MASK;
else
switch(srcVc)
{
default:
fprintf(stderr, "ERROR: Unknown VC: %d (0x%02x)\n", srcVc, srcVc);
exit(-2);
break;

//Ignore this command
case (uint8_t)VC_UNASSIGNED:
return;
}
}

//Done with this command
if (srcVc == myVc)
{
if (pcActiveCommand < CMD_LIST_SIZE)
Expand Down