Skip to content

Fix build with COMPILE_AUTHENTICATION commented out, add to testing #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

Fix build with COMPILE_AUTHENTICATION commented out, add to testing #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Firmware/RTK_Everywhere/Bluetooth.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ void bluetoothStart(bool skipOnlineCheck)
// Uncomment the next line to force deletion of all paired (bonded) devices
// (This should only be necessary if you have changed the SSP pairing type)
//settings.clearBtPairings = true;

// Enable secure pairing without PIN :
// iPhone displays Connection Unsuccessful - but then connects anyway...
bluetoothSerialSpp->enableSSP(false, false);
Expand Down Expand Up @@ -650,6 +650,7 @@ void bluetoothStart(bool skipOnlineCheck)
recordSystemSettings();
}

#ifdef COMPILE_AUTHENTICATION
esp_sdp_init();

esp_bluetooth_sdp_hdr_overlay_t record = {(esp_bluetooth_sdp_types_t)0};
Expand All @@ -663,6 +664,7 @@ void bluetoothStart(bool skipOnlineCheck)
record.service_name = (char *)deviceName;
// record.rfcomm_channel_number = 1; // Doesn't seem to help the failed connects
esp_sdp_create_record((esp_bluetooth_sdp_record_t *)&record);
#endif // COMPILE_AUTHENTICATION
}
}

Expand Down
5 changes: 5 additions & 0 deletions Firmware/RTK_Everywhere/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ set -e
git reset --hard --quiet HEAD
make

# MFi authentication
sed -i 's|#define COMPILE_AUTHENTICATION|//#define COMPILE_AUTHENTICATION|' RTK_Everywhere.ino
make
git reset --hard --quiet HEAD

# Bluetooth
sed -i 's|#define COMPILE_BT|//#define COMPILE_BT|' RTK_Everywhere.ino
make
Expand Down