Skip to content

Fix BIN_HEADER for web config upload #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nseidle merged 2 commits into from
Dec 2, 2025
Merged

Fix BIN_HEADER for web config upload #812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c1ea9
Fix BIN_HEADER for web config upload
PaulZC Dec 2, 2025
5224ec4
Add a comment
PaulZC Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Firmware/RTK_Everywhere/WebServer.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ static void handleFirmwareFileUpload()
{
// Check file name against valid firmware names
const char *BIN_EXT = "bin";
const char *BIN_HEADER = "RTK_Everywhere_Firmware";
const char *BIN_HEADER = "/RTK_Everywhere";

fileName = upload.filename;

Expand All @@ -429,7 +429,7 @@ static void handleFirmwareFileUpload()
// Check 'bin' extension
if (strcmp(BIN_EXT, &fname[strlen(fname) - strlen(BIN_EXT)]) == 0)
{
// Check for 'RTK_Everywhere_Firmware' start of file name
// Check for '/RTK_Everywhere' start of file name
if (strncmp(fname, BIN_HEADER, strlen(BIN_HEADER)) == 0)
{
// Begin update process
Expand Down Expand Up @@ -465,6 +465,10 @@ static void handleFirmwareFileUpload()
}
else
{
// See issue #811
// The Update.write seems to upload the whole file in one go
// This code never gets called...

binBytesSent = upload.currentSize;

// Send an update to browser every 100k
Expand Down