Fixed output for windspeedmph and gps longitude #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed line 445 to Serial.print(",lng="); to fix this issue:
#23
Adding line of code at 178:
windspeedmph = currentSpeed;//update global variable for windspeed when using the printWeather() function
and added comment to line 227 to explain why the calculation was commented out:
//windspeedmph = get_wind_speed(); //This is calculated in the main loop on line 179
to fix this issue => #24
formatting code on line 179
bboyho
referenced
this pull request
in bboyho/Weather_Shield
Jun 22, 2017
I fixed the issue with the _windspeedmph_ in the _Weather_Shield_Weather_Station.ino_ example code [ [https://github.com/sparkfun/Weather_Shield/pull/25](https://github.com/sparkfun/Weather_Shield/pull/25) ]. However, this was also an issue with the _Weather_Shield_with_GPS.ino_ .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #24 for the output for windspeed mph => #24
Fixed issue #23 for the output for gps longitude => #23
Just need to merge the corrections and close the issues. =)