Fix display number for colon and decimal #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printChar(':', 0) is used in several places in the code to turn on the
colon and decimal point. However, the printChar() code resolves the
digit index of 0 to display number 0, but display indexes are one-based
so the colon or decimal chars never get displayed. This commit was only
tested with a single display and this library appears to have larger
limitations with handling colon and decimal chars across multiple
displays.
Here's a test case that this commit fixes:
display.print(" 1:2.3");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printChar(':', 0) is used in several places in the code to turn on the
colon and decimal point. However, the printChar() code resolves the
digit index of 0 to display number 0, but display indexes are one-based
so the colon or decimal chars never get displayed. This commit was only
tested with a single display and this library appears to have larger
limitations with handling colon and decimal chars across multiple
displays.
Here's a test case that this commit fixes:
display.print(" 1:2.3");