Add error handling and remove WProgram.h include #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2019 20:53
jobr97
approved these changes
Dec 28, 2019
|
I'm very late getting to this PR but I really like it. Thank you! The CRC check is especially good. I'll merge here shortly. For future reference, we avoid putting Serial.print statements inside a library. If a user hasn't done a Serial.begin or if they don't have Serial at all (think ATtinys) then a Serial.print can cause their platform to crash. So I'll remove those before pushing a new version. |
|
Thanks for this PR. FYI it broke the library. My fault, I should have been looking at the PR more closely. Don't put Serial.prints in a library. See this post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling: Make sure that if something breaks, the user can choose to address it somehow. I mainly cared about CRC checking because I occasionally saw garbage data.
Remove WProgram.h: This seems to be from an ancient version of Arduino and it breaks compilation when I embed this library in an ESP-IDF component (for the Espressif ESP32).