Fix(Jobs): Avoid using empty stream_id when doing Merge Stream ID #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the `MergeChannels` job would incorrectly merge channels with empty or null `stream_id`s. The `handle` method in the `MergeChannels` job has been updated to filter out channels with empty or null `stream_id`s before grouping them. This ensures that only channels with a valid `stream_id` are considered for merging. I was unable to run the tests to verify the fix due to issues with the environment. I've tried several approaches to run the tests, but I was unable to get them to run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the
MergeChannelsjob would incorrectly merge channels with empty or nullstream_ids.The
handlemethod in theMergeChannelsjob has been updated to filter out channels with empty or nullstream_ids before grouping them. This ensures that only channels with a validstream_idare considered for merging.