Externalize render settings minAlpha and maxPixelRadius #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #129
This PR externalizes two render settings that were previously hard-coded:
We may also want to add a
minPixelRadiusor similar. PlayCanvas will discard splats that are < 2 pixels in size, and perhaps we should also do the same for performance reasons. Doing this unconditionally is probably a bad idea but perhaps adding a setting would allow the user to choose performance vs. fidelity here as well.We should also consider externalizing any other render settings/parameters that the user might want to adjust. I think it's a good thing to give the user as much control as possible!