Copy originToWorld values instead of holding a reference in SplatAccumulator #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SplatAccumulatorkeeps track of atoWorldmatrix. However this was done by holding onto a reference to the matrix passed togenerateSplats. When this matrix is updated outside the accumulator, it holds newer values. This in turn causes origin update checks to incorrectly fail inSparkRenderer, preventing the splats from being updated when they should.See the following reported issue on the Spark Discord server: https://discord.com/channels/1374903240084426855/1379471336329576499/1427230168447193089
This PR changes it so that the values of the matrix are copied over instead.