Skip to content

Conversation

@Philipp-M
Copy link
Contributor

#!/bin/bash is non-standard, #!/usr/bin/env bash should be safer as it's standardized, as /bin/bash for instance doesn't exist on my system.

Additionally there are users (like me... this likely concerns a few NixOS users) who aren't using rustup, I've extended the script, such that it checks whether the rust target directory exists, in which case it's very likely that the required rust toolchain/target is on the system.
Similar for wasm-pack which might already be installed on the system without using cargo install.

@dmarcos
Copy link
Contributor

dmarcos commented Oct 21, 2025

Thank you!

@dmarcos dmarcos merged commit 589b6bc into sparkjsdev:main Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants