Skip to content

Allow disabling multi-touch roll in SparkControls/PointerControls #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 1 commit into from
Jun 21, 2025
Merged

Allow disabling multi-touch roll in SparkControls/PointerControls #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/controls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const DEFAULT_ROTATE_INERTIA = 0.15;
const DEFAULT_MOVE_INERTIA = 0.15;
const DEFAULT_STICK_THRESHOLD = 0.1;
const DEFAULT_FPS_ROTATE_SPEED = 2.0;
const DEFAULT_POINTER_ROLL_SCALE = 1.0;

// Time limit for double-finger press (pinch etc)
const DUAL_PRESS_MS = 200;
Expand Down Expand Up @@ -352,6 +353,7 @@ export class PointerControls {
reverseScroll: boolean;
moveInertia: number;
rotateInertia: number;
pointerRollScale: number;
// Enable/disable controls updates
enable = true;

Expand Down Expand Up @@ -404,6 +406,8 @@ export class PointerControls {
moveInertia,
// Inertia factor for rotation (default: DEFAULT_ROTATE_INERTIA)
rotateInertia,
// Pointer rolling scale factor (default: DEFAULT_POINTER_ROLL_SCALE)
pointerRollScale,
// Callback for double press events (default: () => {})
doublePress,
}: {
Expand All @@ -418,6 +422,7 @@ export class PointerControls {
reverseScroll?: boolean;
moveInertia?: number;
rotateInertia?: number;
pointerRollScale?: number;
doublePress?: ({
position,
intervalMs,
Expand All @@ -434,6 +439,7 @@ export class PointerControls {
this.reverseScroll = reverseScroll ?? false;
this.moveInertia = moveInertia ?? DEFAULT_MOVE_INERTIA;
this.rotateInertia = rotateInertia ?? DEFAULT_ROTATE_INERTIA;
this.pointerRollScale = pointerRollScale ?? DEFAULT_POINTER_ROLL_SCALE;

this.doublePress = doublePress ?? (() => {});
this.doublePressLimitMs = DOUBLE_PRESS_LIMIT_MS;
Expand Down Expand Up @@ -617,7 +623,7 @@ export class PointerControls {
Math.atan(motionOrtho[0] / (-0.5 * deltaDist)),
Math.atan(motionOrtho[1] / (0.5 * deltaDist)),
];
const rotate = 0.5 * (angles[0] + angles[1]);
const rotate = 0.5 * (angles[0] + angles[1]) * this.pointerRollScale;
const eulers = new THREE.Euler().setFromQuaternion(
control.quaternion,
"YXZ",
Expand Down