Use RenderTarget properties to reduce manual render state tracking #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PackedSplatsandReadbackclasses kept track of various properties of the render state in order to restore them afterwards. TheWebGLRenderTargethas properties forscissor/scissorTestwhich, when used, cause theWebGLRendererto keep track of and restore them for us when switching render targets. This simplifies the code as there is less state to track and no longer a need to adjust thepixelRatio(as this doesn't apply to render targets).I've also changed the
xrPresentingtoxrEnabled, since theisPresentingflag is considered readonly in Three.js (WebXRManager.js#L100-L107). Temporarily disabling the WebXR code paths in the renderer should be done by settingxr.enabledto false, as can also be seen in theReflectorfor example (Reflector.js#L201).