Fix compressed PLY loading from older versions of SS. #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this file: https://github.com/user-attachments/files/20961347/baltimore.ps.cleaned.compressed2.ply.zip
Looking at the PLY header we see this:
Interestingly for newer exports for SS compressed PLY the header looks like this:
So newer exports from SS of compressed PLY also include min/max_r/g/b in their chunk properties, while older SS (possibly 1.* instead of 2.*?) don't include it. Looking through PlayCanvas sources it seems that if they aren't specified we simply assume min/max = 0/1 for those properties.
Loading it in Spark Editor vs. Super Splat appears to validate this approach. I'm able to load the above mentioned file in Spark without a problem now. This addresses the particular file loading issue in #72 .