Merge of MBL-19 #108
Merged
Merge of MBL-19 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#94) * MBL-19 Remove some hard coded thing in ADeploymentsPlayerController and keep existing features.
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/MBL-19 |
improbable-prow-robot
added
jira/MBL
size/M
MatthewSandfordImprobable
requested review from
samiwh
and removed request for
mironec
jessicafalk
reviewed
Mar 2, 2020
There was a problem hiding this comment.
this looks like it's a direct port, so should be fine to be merged in, if the changes in the other PR go in.
Added comments on the lines that I think are the main culprit for the issue that got reported. so, I'm not sur if we need to merge al the changes from those PRs in.
|
|
||
| const FDevAuthConfig& DevAuthConfig = SpatialWorkerConnection->DevAuthConfig; | ||
| FURL TravelURL; | ||
| TravelURL.Host = TEXT("locator.improbable.io"); |
There was a problem hiding this comment.
that is the line that I think is causing the issues in the linked jira ticket.
| PITParams->metadata = ""; | ||
| PITParams->use_insecure_connection = false; | ||
|
|
||
| Worker_Alpha_PlayerIdentityTokenResponseFuture* PITFuture = Worker_Alpha_CreateDevelopmentPlayerIdentityTokenAsync("locator.improbable.io", 444, PITParams); |
There was a problem hiding this comment.
here as well, also might need to double check the port
| Worker_Alpha_LoginTokensRequest* LTParams = new Worker_Alpha_LoginTokensRequest(); | ||
| LTParams->player_identity_token = LatestPITokenData; | ||
| LTParams->worker_type = "UnrealClient"; | ||
| Worker_Alpha_LoginTokensResponseFuture* LTFuture = Worker_Alpha_CreateDevelopmentLoginTokensAsync("locator.improbable.io", 444, LTParams); |
jessicafalk
approved these changes
Mar 2, 2020
oblm
added a commit
that referenced
this pull request
Mar 17, 2020
* [UNR-1715][MS] Fix for error messages being deisplayed when character is killed. (#89) Essentially there is a race on death between the health component being updated and the player controller unpossessing it's character actor. I have just added a delay as a quick hacky fix so that both updates are recieved. * Decrementing player count when player disconnects. (#98) * [UNR-2425][MS] Fixing bug with sim players not moving. * [UNR-2608][MS] Decrementing player count when player disconnects. * Revert "[UNR-2425][MS] Fixing bug with sim players not moving." This reverts commit 3c662ca. * Fixing none component on Player character. (#100) The Nameplate component had "Owner no see" enabled which means that the component will not exist for the owner of the actor. The fix is simply to check the Nameplate component before using it. # Conflicts: # Game/Content/Characters/BP_FPS_Character.uasset * Merge of MBL-19 (#108) * MBL-19 Remove some hard coded logics in ADeploymentsPlayerController. (#94) * MBL-19 Remove some hard coded thing in ADeploymentsPlayerController and keep existing features. * Update to player controller. * Removing tryloadfromcommandline as it is unecessary for release. Co-authored-by: wangxin <raymonwang@improbable.io> * [CHINF-886][MS] Fixing a crash caused by the merge into release related to the jira issue. (#111) * [UNR-3041][MS] Addin 14.3 into release (#112) * Crash fix when hitting cancel button. (#114) * [UNR-3071][MS] Updating Worker SDK version to 14.5 (#116) * Readme update: new docs site + maturity guidelines * More docs links updates * Update DefaultSpatialGDKSettings.ini Co-authored-by: MatthewSandfordImprobable <matthewsandford@improbable.io> Co-authored-by: wangxin <raymonwang@improbable.io> Co-authored-by: Ernest Oppetit <ernest@improbable.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue:
https://improbableio.atlassian.net/browse/CHINF-886