Skip to content

Conversation

mattyoung-improbable
Copy link
Contributor

Offloading workers AIWorker / CrashWorker should not start by default in example project. Disabling offloading should have this effect.

Offloading workers AIWorker / CrashWorker should not start by default in example project. Disabling offloading should have this effect.
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Aug 9, 2019
@mattyoung-improbable mattyoung-improbable changed the title Disable offloading by default Disable offloading by default UNR-1886 Aug 9, 2019
@improbable-prow-robot improbable-prow-robot removed the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Aug 9, 2019
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1886

@mattyoung-improbable mattyoung-improbable merged commit d87ca4d into 0.6.1-hotfix Aug 13, 2019
@mattyoung-improbable mattyoung-improbable deleted the bugfix/disable-offloading-by-deafult branch August 13, 2019 13:05
oblm added a commit that referenced this pull request Aug 15, 2019
* DOC-1255 Clarify elements of the GDK in readme (#43)

* Clarify elements of the GDK

* Remove duplicate and outdated info

* Changes from review

* Add two_worker_test for tutorial (#44)

* Disable offloading by default (#45)

Offloading workers AIWorker / CrashWorker should not start by default in example project. Disabling offloading should have this effect.

* Add Calls to Parent BeginPlay in Character Classes (#46)

In AGDKCharacter::BeginPlay a callback is registered on the UEquippedComponent::HoldableUpdated. This callback is used to attach the new AHoldable to the player's skeleton.

Blueprint subclasses: BP_Base_Character, and BP_FPS_Character had overridden BeginPlay but not called the Parent function, so the callback was not attached.

This meant that if a weapon was checked out after the character, it would not be attached, and would stay floating where it was spawned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/UNR size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants