[UNR-1888] Bugfix: Guns were not being attached to players sometimes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1888 |
1 similar comment
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1888 |
improbable-prow-robot
added
jira/UNR
size/XS
mattyoung-improbable
force-pushed
the
bugfix/stuck-guns
branch
from
23ee989 to
73d0fb9
Compare
improbable-valy
approved these changes
Aug 14, 2019
oblm
added a commit
that referenced
this pull request
Aug 15, 2019
* DOC-1255 Clarify elements of the GDK in readme (#43) * Clarify elements of the GDK * Remove duplicate and outdated info * Changes from review * Add two_worker_test for tutorial (#44) * Disable offloading by default (#45) Offloading workers AIWorker / CrashWorker should not start by default in example project. Disabling offloading should have this effect. * Add Calls to Parent BeginPlay in Character Classes (#46) In AGDKCharacter::BeginPlay a callback is registered on the UEquippedComponent::HoldableUpdated. This callback is used to attach the new AHoldable to the player's skeleton. Blueprint subclasses: BP_Base_Character, and BP_FPS_Character had overridden BeginPlay but not called the Parent function, so the callback was not attached. This meant that if a weapon was checked out after the character, it would not be attached, and would stay floating where it was spawned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AGDKCharacter::BeginPlay a callback is registered on the UEquippedComponent::HoldableUpdated. This callback is used to attach the new AHoldable to the player's skeleton.
Blueprint subclasses: BP_Base_Character, and BP_FPS_Character had overridden BeginPlay but not called the Parent function, so the callback was not attached.
This meant that if a weapon was checked out after the character, it would not be attached, and would stay floating where it was spawned.
Tests
Tested in cloud deployment with human + sim players. Saw no floating guns / empty-handed players (which were quite common)
Blueprint Diffs
