This repository was archived by the owner on Oct 20, 2021. It is now read-only.
Bake navmesh to SimulatedPlayerCoordinator scene #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
paulbalaji
changed the title
paulbalaji
changed the title
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
BenNaccarato
pushed a commit
that referenced
this pull request
Dec 14, 2018
**Contributions**: We are not currently taking public contributions - see our [contributions](https://github.com/spatialos/UnityGDK/blob/master/CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](https://github.com/spatialos/UnityGDK/blob/master/README.md#give-us-feedback). ------- #### Description Couple small changes: * Enforce local links for links in the repository. This makes the linking more reliable and easier to test (for example a remote link to a invalid heading in a markdown file will not fail, whereas local links will) as well as running through the linter faster. * Allowed local links to directories * Added more logging for when a remote link check throws an exception. * Made changes to all the `md` files that were in violation of the first point. * Added dotenv file to track the remote url. This is used for the enforcement of links and in the docs verification branch. #### Tests Ran `ci/docs-lint.sh` and added tests to the project for the new conditions. #### Documentation This is documentation? We might want to add a style guide for markdown to enforce local links. #### Primary reviewers If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them. @firtina-improbable @ElleEss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
adds navmesh to
FPS-SimulatedPlayerCoordinatorsceneTests
matches the one in the
FPS-DevelopmentsceneDocumentation
none needed
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.