ENG-1281: trigger.sh is no longer necessary. #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1281 replaces trigger.sh with `imp-ci steps run --from ...steps.yaml`.
If, after this deletion, your pipeline fails to run, you should:
```bash
cd {repo-root}
circle ci pipeline push -n {name}
```
and retry, because (apologies) I must have missed it when I bulk-updated pipelines in BuildKite.
The pipeline definition _within the buildkite pipeline settings page_ should resemble:
```yaml
steps:
- agents:
- environment=production
- queue=trigger-pipelines
command: imp-ci steps run --from .buildkite/premerge.steps.yaml
label: premerge
retry:
automatic:
- exit_status: -1
limit: 3
timeout_in_minutes: 10
- wait: wait-for-steps-upload
```
The two differences that my change makes are
* ENG-1281: the change to the command step from `.buildkite/trigger.sh {name}.steps.yaml` to `imp-ci steps run --from {name}.steps.yaml`
* ENG-1450: the addition of the `- wait: wait-for-steps-upload` _after_ the `command` step (to eliminate a race condition when cancelling a pipeline).
petemounce
requested review from
Helcaraxan and
RNabel
and removed request for
achannn
Helcaraxan
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-1281 replaces trigger.sh with
imp-ci steps run --from ...steps.yaml.If, after this deletion, your pipeline fails to run, you should:
cd {repo-root} circle ci pipeline push -n {name}and
rebuild, because (apologies) I must have missed it when I bulk-updated pipelines in BuildKite.The pipeline definition within the buildkite pipeline settings page should resemble:
The two differences that my change makes are
.buildkite/trigger.sh {name}.steps.yamltoimp-ci steps run --from {name}.steps.yaml- wait: wait-for-steps-uploadafter thecommandstep (to eliminate a race condition when cancelling a pipeline).