Skip to content

Conversation

spaze
Copy link
Owner

@spaze spaze commented Sep 20, 2025

Follow-up:

@spaze spaze requested a review from Copilot September 20, 2025 15:46
@spaze spaze self-assigned this Sep 20, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to use PHP_CodeSniffer 4.0 by upgrading dependencies and adjusting coding standards rules to maintain compatibility. The changes align with PHPCS 4.0's breaking changes while maintaining the same code quality standards.

  • Updates PHP version requirement from 7.2 to 7.4 to match PHPCS 4.0 requirements
  • Upgrades slevomat/coding-standard to version that supports PHPCS 4.0
  • Replaces deprecated PSR12.Files.FileHeader.SpacingAfterBlock rule with new modular PSR12.Files.FileHeader.SpacingAfterTagBlock

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
composer.json Updates PHP version requirement and slevomat/coding-standard dependency
src/ruleset.xml Replaces deprecated PHPCS rule with new modular equivalent

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@spaze spaze merged commit 887cc84 into main Sep 20, 2025
4 checks passed
@spaze spaze deleted the spaze/phpcs-4 branch September 20, 2025 15:50
spaze added a commit that referenced this pull request Sep 24, 2025
Sometimes, there are some file-level docblocks and they don't need to be separated with an empty line.

Follow-up to #29
spaze added a commit that referenced this pull request Sep 24, 2025
Sometimes, there are some file-level docblocks and they don't need to be separated with an empty line.

Follow-up to #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant