Skip to content

Record count null updates #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Record count null updates #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b1dcd7
add check for null in payload
Nov 3, 2023
41c54f8
return live object versions based on live object id
Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-api/src/routes/live-object-version/liveObjectVersionPayloads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export function parseGetLiveObjectVersionPayload(
export function parseLovRecordCountsPayload(data: StringKeyMap): ValidatedPayload<LovRecordCountsPayload> {
const ids = data?.ids || []

if (!ids.length) {
if (!ids.length || ids.includes(null)) {
return { isValid: false, error: '"ids" was missing or empty' }
}

Expand Down
2 changes: 1 addition & 1 deletion core-api/src/routes/namespace/namespacePayloads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function parseGetNamespacePayload(data: StringKeyMap): ValidatedPayload<G
export function parseNamespaceRecordCountsPayload(data: StringKeyMap): ValidatedPayload<NamespaceRecordCountsPayload> {
const nsps = data?.nsps || []

if (!nsps.length) {
if (!nsps.length || nsps.includes(null)) {
return { isValid: false, error: '"nsps" was missing or empty' }
}

Expand Down
7 changes: 6 additions & 1 deletion shared/src/lib/core/db/services/liveObjectVersionServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,18 @@ export async function resolveLovWithPartialId(someId: string): Promise<StringKey
export async function getTablePathsForLiveObjectVersions(uids: string[]): Promise<string[] | null> {
try {
const lovs = await liveObjectVersions().find({
relations: {
liveObject: true,
},
select: {
config: {
table: true,
},
},
where: {
uid: In(uids),
liveObject: {
uid: In(uids),
},
},
})
return lovs.map((lov) => lov.config.table)
Expand Down