fix: added script to check for and delete packer cache #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennessyy
requested review from
addetz,
caroldelwing and
karl-cardenas-coding
and removed request for
a team
Contributor
Author
|
I added some logic so it doesn't throw an error if it doesn't find existing cache. |
karl-cardenas-coding
requested changes
Nov 13, 2023
Collaborator
karl-cardenas-coding
left a comment
karl-cardenas-coding
left a comment
There was a problem hiding this comment.
Feedback provided.
| source /edge/vmware/clone_vm_template/setenv.sh | ||
|
|
||
| # Check if the packer cache exists | ||
| CACHE_EXISTS=$(govc datastore.ls -ds=$vcenter_datastore /packer_cache 2>/dev/null) |
Collaborator
There was a problem hiding this comment.
I'm not sure sending to null is the answer. What if the error is related due to access? I think if an error, then we should output that error to help the user.
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
lennessyy
commented
Nov 13, 2023
change error output destination
karl-cardenas-coding
approved these changes
Nov 13, 2023
#25) * fix: added new tools such as oras and awscli, updated Terraform files to include OCI registries * chore: updated the template and documentation * docs: minor update to the terraform.tfvars file * docs: minor update to the terraform.tfvars file --------- Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
|
🎉 This PR is included in version 1.0.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds a script to the tutorials container that checks for existing packer cache. If it is found, the script deletes it.
Review Changes
🎫 Jira Ticket